Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-26317][BUILD] Upgrade SBT to 0.13.18 #23270

Closed
wants to merge 1 commit into from
Closed

[SPARK-26317][BUILD] Upgrade SBT to 0.13.18 #23270

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 10, 2018

What changes were proposed in this pull request?

SBT 0.13.14 ~ 1.1.1 has a bug on accessing java.util.Base64.getDecoder with JDK9+. It's fixed at 1.1.2 and backported to 0.13.18 (released on Nov 28th). This PR aims to update SBT.

How was this patch tested?

Pass the Jenkins with the building and existing tests.

@SparkQA
Copy link

SparkQA commented Dec 10, 2018

Test build #99897 has finished for PR 23270 at commit 0885c94.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 10, 2018

Test build #99898 has finished for PR 23270 at commit 0885c94.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 10, 2018

Test build #99918 has finished for PR 23270 at commit 0885c94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

cc @srowen and @dbtsai

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for 3.0 to ensure JDK 9+ support.

@dbtsai
Copy link
Member

dbtsai commented Dec 10, 2018

LGTM.

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen and @dbtsai and @HyukjinKwon . Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-26317 branch December 10, 2018 20:09
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

SBT 0.13.14 ~ 1.1.1 has a bug on accessing `java.util.Base64.getDecoder` with JDK9+. It's fixed at 1.1.2 and backported to [0.13.18 (released on Nov 28th)](https://github.com/sbt/sbt/releases/tag/v0.13.18). This PR aims to update SBT.

## How was this patch tested?

Pass the Jenkins with the building and existing tests.

Closes apache#23270 from dongjoon-hyun/SPARK-26317.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants