[SPARK-26322][SS] Add spark.kafka.sasl.token.mechanism to ease delegation token configuration. #23274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion token configuration.
gaborgsomogyi
commented
Dec 10, 2018
| @@ -642,9 +642,9 @@ This way the application can be configured via Spark parameters and may not need | |||
| configuration (Spark can use Kafka's dynamic JAAS configuration feature). For further information | |||
| about delegation tokens, see [Kafka delegation token docs](http://kafka.apache.org/documentation/#security_delegation_token). | |||
|
|
|||
| The process is initiated by Spark's Kafka delegation token provider. When `spark.kafka.bootstrap.servers`, | |||
| The process is initiated by Spark's Kafka delegation token provider. When `spark.kafka.bootstrap.servers` set, | |||
There was a problem hiding this comment.
I've found this wording issue so fixed it here.
There was a problem hiding this comment.
In that case, it should be "is set".
gaborgsomogyi
commented
Dec 10, 2018
| Spark considers the following log in options, in order of preference: | ||
| - **JAAS login configuration** | ||
| - **JAAS login configuration**, please see example below. |
There was a problem hiding this comment.
Added this small pointer to make things more clear.
There was a problem hiding this comment.
Hi, @gaborgsomogyi . Which example is this pointing? Previous examples seems to be removed.
There was a problem hiding this comment.
@dongjoon-hyun down below with the same JAAS login configuration name.
|
Test build #99917 has finished for PR 23274 at commit
|
|
The feature works on cluster but I'm not fully happy with the |
core/src/main/scala/org/apache/spark/internal/config/Kafka.scala
Outdated
Show resolved
Hide resolved
vanzin
reviewed
Dec 10, 2018
| @@ -642,9 +642,9 @@ This way the application can be configured via Spark parameters and may not need | |||
| configuration (Spark can use Kafka's dynamic JAAS configuration feature). For further information | |||
| about delegation tokens, see [Kafka delegation token docs](http://kafka.apache.org/documentation/#security_delegation_token). | |||
|
|
|||
| The process is initiated by Spark's Kafka delegation token provider. When `spark.kafka.bootstrap.servers`, | |||
| The process is initiated by Spark's Kafka delegation token provider. When `spark.kafka.bootstrap.servers` set, | |||
There was a problem hiding this comment.
In that case, it should be "is set".
|
Test build #99963 has finished for PR 23274 at commit
|
|
Test build #99986 has finished for PR 23274 at commit
|
|
retest this, please |
gaborgsomogyi
changed the title
|
Test build #99991 has finished for PR 23274 at commit
|
HeartSaVioR
approved these changes
Dec 12, 2018
|
Merging to master. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
…tion token configuration. ## What changes were proposed in this pull request? When Kafka delegation token obtained, SCRAM `sasl.mechanism` has to be configured for authentication. This can be configured on the related source/sink which is inconvenient from user perspective. Such granularity is not required and this configuration can be implemented with one central parameter. In this PR `spark.kafka.sasl.token.mechanism` added to configure this centrally (default: `SCRAM-SHA-512`). ## How was this patch tested? Existing unit tests + on cluster. Closes apache#23274 from gaborgsomogyi/SPARK-26322. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…tion token configuration. ## What changes were proposed in this pull request? When Kafka delegation token obtained, SCRAM `sasl.mechanism` has to be configured for authentication. This can be configured on the related source/sink which is inconvenient from user perspective. Such granularity is not required and this configuration can be implemented with one central parameter. In this PR `spark.kafka.sasl.token.mechanism` added to configure this centrally (default: `SCRAM-SHA-512`). ## How was this patch tested? Existing unit tests + on cluster. Closes apache#23274 from gaborgsomogyi/SPARK-26322. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When Kafka delegation token obtained, SCRAM
sasl.mechanismhas to be configured for authentication. This can be configured on the related source/sink which is inconvenient from user perspective. Such granularity is not required and this configuration can be implemented with one central parameter.In this PR
spark.kafka.sasl.token.mechanismadded to configure this centrally (default:SCRAM-SHA-512).How was this patch tested?
Existing unit tests + on cluster.