[MINOR] Fix inconsistency log level among delegation token providers #23418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some inconsistency for log level while logging error messages in delegation token providers. (DEBUG, INFO, WARNING) Given that failing to obtain token would often crash the query, I guess it would be nice to set higher log level for error log messages.
|
Test build #100580 has finished for PR 23418 at commit
|
srowen
reviewed
Dec 31, 2018
| nextRenewalDate | ||
| nextRenewalDate | ||
| } catch { | ||
| case NonFatal(e) => |
There was a problem hiding this comment.
This seems to change behavior - is it pretty clearly OK, or is it necessary?
There was a problem hiding this comment.
This is another one of inconsistency between HDFS delegation token provider and others. While others log the error message and swallow the exception, this doesn't swallow the exception.
Personally I prefer not to swallow the error, but majority are swallowing so I just changed this. Please let me know if we think it would be better to re-raise the exception.
If we are unclear about this, I'm OK to make changes to only log level.
srowen
approved these changes
Dec 31, 2018
HyukjinKwon
approved these changes
Jan 1, 2019
|
Merged to master. |
|
Thanks @srowen and @HyukjinKwon for reviewing and merging! |
HeartSaVioR
deleted the
FIX-inconsistency-log-level-between-delegation-token-providers
branch
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? There's some inconsistency for log level while logging error messages in delegation token providers. (DEBUG, INFO, WARNING) Given that failing to obtain token would often crash the query, I guess it would be nice to set higher log level for error log messages. ## How was this patch tested? The patch just changed the log level. Closes apache#23418 from HeartSaVioR/FIX-inconsistency-log-level-between-delegation-token-providers. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There's some inconsistency for log level while logging error messages in
delegation token providers. (DEBUG, INFO, WARNING)
Given that failing to obtain token would often crash the query, I guess
it would be nice to set higher log level for error log messages.
How was this patch tested?
The patch just changed the log level.