[SPARK-25935][SQL] Allow null rows for bad records from JSON parsers #23543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @HyukjinKwon @attilapiros Please, take a look at the PR. |
MaxGekk
changed the title
This reverts commit 38628dd.
MaxGekk
force-pushed
the
return-nulls-from-json-parser
branch
from
6574db0 to
69a4284
Compare
|
Yup, I agree with it for now. |
|
Test build #101209 has finished for PR 23543 at commit
|
|
Test build #101210 has finished for PR 23543 at commit
|
|
thanks, merging to master! |
|
Should the PR title be "Allow null rows for bad records from JSON parsers"? |
cloud-fan
changed the title
|
good catch! I've updated the title |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR reverts apache#22938 per discussion in apache#23325 Closes apache#23325 Closes apache#23543 from MaxGekk/return-nulls-from-json-parser. Authored-by: Maxim Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts #22938 per discussion in #23325
Closes #23325