Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor #23854

Closed
wants to merge 13 commits into from
Closed

[SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor #23854

wants to merge 13 commits into from

Commits on Feb 21, 2019

  1. [SPARK-22000][SQL] Use String.valueOf to assign value to String type … 

    …of field in Java Bean
    @HeartSaVioR
    HeartSaVioR committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    acd5d55 View commit details
    Browse the repository at this point in the history

  2. Address review comments from maropu

    @HeartSaVioR
    HeartSaVioR committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    443e74f View commit details
    Browse the repository at this point in the history

  3. Address review comments from srowen, as well as fix style

    @HeartSaVioR
    HeartSaVioR committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    d869bba View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Apply cloud-fan's suggestion: address Upcast in JavaTypeInference

    @HeartSaVioR
    HeartSaVioR committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    60ca088 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Fix java lint

    @HeartSaVioR
    HeartSaVioR committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    9eeb391 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Refactor: extract duplicated codes in deserializerFor between ScalaRe… 

    …flection and JavaTypeInference
    @HeartSaVioR
    HeartSaVioR committed Feb 25, 2019
    1 Configuration menu
    Copy the full SHA
    d4c2060 View commit details
    Browse the repository at this point in the history

  2. Add new test: upcast doesn't help making Dataset be compatible with J… 

    …ava Bean Encoder
    @HeartSaVioR
    HeartSaVioR committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    9c040e2 View commit details
    Browse the repository at this point in the history

  3. Address review comments from cloud-fan

    @HeartSaVioR
    HeartSaVioR committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    2007452 View commit details
    Browse the repository at this point in the history

  4. Address weird style from ScalaReflection as well

    @HeartSaVioR
    HeartSaVioR committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    4d564ab View commit details
    Browse the repository at this point in the history

  5. Fix build failure due to slightly change of walked type path represen… 

    …tation
    @HeartSaVioR
    HeartSaVioR committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    e01bfe6 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Address review comments from cloud-fan & maropu

    @HeartSaVioR
    HeartSaVioR committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    8cbad26 View commit details
    Browse the repository at this point in the history

  2. Revert back wrong change and sync again with ScalaReflection implemen… 

    …tation
    @HeartSaVioR
    HeartSaVioR committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    7ff01db View commit details
    Browse the repository at this point in the history

  3. Apply preferred code style to both JavaTypeInference and ScalaReflection

    @HeartSaVioR
    HeartSaVioR committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    24a1b19 View commit details
    Browse the repository at this point in the history