Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3531][SQL]select null from table would throw a MatchError #2396

Closed
wants to merge 1 commit into from

Conversation

adrian-wang
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have started for PR 2396 at commit 0981c42.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have finished for PR 2396 at commit 0981c42.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@adrian-wang
Copy link
Contributor Author

This is according to how Hive handle immediate null value in queries.

@@ -632,6 +632,12 @@ class HiveQuerySuite extends HiveComparisonTest {
clear()
}

test("select null from table") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to create a query test, since then it actually checks to make sure hive is returning the same answer.

@adrian-wang
Copy link
Contributor Author

Thanks, Michael, I've moved the test as a query test.

@SparkQA
Copy link

SparkQA commented Sep 17, 2014

QA tests have started for PR 2396 at commit ac4fb5d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 17, 2014

QA tests have finished for PR 2396 at commit ac4fb5d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have started for PR 2396 at commit 2458229.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20738/

@adrian-wang
Copy link
Contributor Author

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have started for PR 2396 at commit 2458229.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have finished for PR 2396 at commit 2458229.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20739/

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have finished for PR 2396 at commit 2458229.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20740/

@marmbrus
Copy link
Contributor

Thanks :) Merged to master.

@asfgit asfgit closed this in 0ec2d2e Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants