-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-23014][SS] Fully remove V1 memory sink. #24403
Conversation
Just for the sake of understanding why python adaptation needed.
With V2 memory sink the following exception arrived (here additional exceptions are linked to the top level one, for instance
|
Test build #104701 has finished for PR 24403 at commit
|
Test build #104702 has finished for PR 24403 at commit
|
Test build #104705 has finished for PR 24403 at commit
|
Test build #104713 has finished for PR 24403 at commit
|
Test build #104714 has finished for PR 24403 at commit
|
cc @jose-torres since you've started this originally and @HyukjinKwon because of the python change. |
Not much movement cc @vanzin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things.
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memory.scala
Outdated
Show resolved
Hide resolved
Test build #104992 has finished for PR 24403 at commit
|
728fa06
to
91d35a0
Compare
Test build #104999 has finished for PR 24403 at commit
|
Test build #105000 has finished for PR 24403 at commit
|
Test build #104995 has finished for PR 24403 at commit
|
Test build #105001 has finished for PR 24403 at commit
|
Merging to master. |
There is a MemorySink v2 already so v1 can be removed. In this PR I've removed it completely. What this PR contains: * V1 memory sink removal * V2 memory sink renamed to become the only implementation * Since DSv2 sends exceptions in a chained format (linking them with cause field) I've made python side compliant * Adapted all the tests Existing unit tests. Closes apache#24403 from gaborgsomogyi/SPARK-23014. Authored-by: Gabor Somogyi <gabor.g.somogyi@gmail.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
What changes were proposed in this pull request?
There is a MemorySink v2 already so v1 can be removed. In this PR I've removed it completely.
What this PR contains:
How was this patch tested?
Existing unit tests.