-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28221][BUILD] Upgrade janino to 3.0.13 #25021
Conversation
Test build #107066 has finished for PR 25021 at commit
|
Just a question: skips 3.0.12? It seems the change logs for 3.0.13 are listed in the description. |
Thank you @maropu I added some change logs for 3.0.12. |
Looks good to me One question. Do you wait for confirming the fix of this issue? @JoshRosen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay. +1, LGTM, too. So, we are waiting @JoshRosen 's confirmation about janino-compiler/janino#90, right?
Retest this please. |
Gentle ping, @JoshRosen . It would be really great if we can get a confirmation from you. |
Test build #107290 has finished for PR 25021 at commit
|
I haven't had a chance to confirm the Janino bugfix yet, but I don't think that's a blocker to merging this version bump: AFAIK we're not relying on the patched functionality yet. |
I see. Great. Thank you so much, @JoshRosen . Also, Thank you, @wangyum , @kiszk , @srowen , @maropu , @HyukjinKwon ! |
What changes were proposed in this pull request?
Mainly change logs:
Version 3.0.13:
Minor refactoring: Allowed modifiers are now checked in the Parser, not in Java.*. This saves a lot of THROWS clauses.
Version 3.0.12
http://janino-compiler.github.io/janino/changelog.html
How was this patch tested?
Existing test