[Build] Diff from branch point #2512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 2512 at commit
|
|
QA tests have finished for PR 2512 at commit
|
|
Test PASSed. |
| @@ -92,13 +92,13 @@ function post_message () { | |||
| merge_note=" * This patch merges cleanly." | |||
|
|
|||
| source_files=$( | |||
| git diff master --name-only \ | |||
| git diff master... --name-only `# diff patch against master from branch piont` \ | |||
|
QA tests have started for PR 2512 at commit
|
|
QA tests have finished for PR 2512 at commit
|
|
Test PASSed. |
|
Looks good - thanks Nick. |
|
@pwendell Should this also be merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Jenkins posts spurious reports of new classes being added. I believe this stems from diffing the patch against
master, as opposed to againstmaster..., which starts from the commit the PR was branched from.This patch fixes that behavior.