Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3476] Remove outdated memory checks in Yarn #2528

Closed
wants to merge 2 commits into from

Conversation

andrewor14
Copy link
Contributor

See description in JIRA.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20772/

@andrewor14
Copy link
Contributor Author

Man, test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20773/

@andrewor14
Copy link
Contributor Author

Tested this on yarn cluster. Tests are failing because of git exception. Let's wait a little before retesting this.

@sryza
Copy link
Contributor

sryza commented Sep 25, 2014

The changes conceptually look good to me.

@tgravescs
Copy link
Contributor

Yeah changes look good if Jenkins passes. We now have a map and for loop a single instance so we probably could condense it but not a big deal.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2528 at commit c5400cd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2528 at commit c5400cd.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20813/

@andrewor14
Copy link
Contributor Author

Yup, I have simplified it in my latest commit. Does this LGTYG?

@tgravescs
Copy link
Contributor

yep, looks good. Thanks!

@andrewor14
Copy link
Contributor Author

Ok, I'm merging this.

@asfgit asfgit closed this in 8da10bf Sep 26, 2014
@andrewor14 andrewor14 deleted the yarn-memory-checks branch September 26, 2014 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants