Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-1307 [DOCS] Don't use term 'standalone' to refer to a Spark Application #2787

Closed
wants to merge 1 commit into from

Conversation

srowen
Copy link
Member

@srowen srowen commented Oct 13, 2014

HT to Diana, just proposing an implementation of her suggestion, which I rather agreed with. Is there a second/third for the motion?

Refer to "self-contained" rather than "standalone" apps to avoid confusion with standalone deployment mode. And fix placement of reference to this in MLlib docs.

…usion with standalone deployment mode. And fix placement of reference to this in MLlib docs.
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21697/
Test FAILed.

@andrewor14
Copy link
Contributor

I think this is a good idea. I'll leave this here so others can comment, but this LGTM as it is.

@mengxr
Copy link
Contributor

mengxr commented Oct 14, 2014

test this please

@mengxr
Copy link
Contributor

mengxr commented Oct 14, 2014

LGTM too. Waiting for Jenkins.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21741/
Test FAILed.

@andrewor14
Copy link
Contributor

We probably don't need to run tests on this one since it modifies only docs.

@mengxr
Copy link
Contributor

mengxr commented Oct 14, 2014

I tested locally but It is still safer to see Jenkins happy.

@mengxr
Copy link
Contributor

mengxr commented Oct 14, 2014

test this please

@SparkQA
Copy link

SparkQA commented Oct 14, 2014

QA tests have started for PR 2787 at commit b5b82e2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 15, 2014

QA tests have finished for PR 2787 at commit b5b82e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21749/
Test PASSed.

@asfgit asfgit closed this in 18ab6bd Oct 15, 2014
@mengxr
Copy link
Contributor

mengxr commented Oct 15, 2014

Merged into master. Thanks!

@srowen srowen deleted the SPARK-1307 branch October 16, 2014 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants