-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-3944][Core] Code re-factored as suggested #2810
Conversation
Can one of the admins verify this patch? |
ok to test |
Hi @Shiti , could you write a less cryptic PR title? This becomes the git commit summary, so it's recommended that it describe the actual change. Thanks! |
add to whitelist |
Option(uri.getScheme) match { | ||
case Some("http") | Some("https") | Some("ftp") => | ||
Option(uri.getScheme).getOrElse("file") match { | ||
case "http"|"https"|"ftp" => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need spaces around |
QA tests have started for PR 2810 at commit
|
QA tests have finished for PR 2810 at commit
|
Test PASSed. |
…e" or None yields the same result
QA tests have started for PR 2810 at commit
|
QA tests have finished for PR 2810 at commit
|
Test PASSed. |
@markhamstra does this LGTY? |
Yup, LGTM. And as a general rule for the future, avoid pattern matching on Some and None. In most cases you should instead use a map, flatMap or foreach over the Option. Even, as in this instance, when you can't do that, matching on Some and None isn't good Scala style. |
Alright, I'm merging this. |
No description provided.