[SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server #28723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HyukjinKwon Please, review this PR. |
|
Looks good if the tests pass. WDYT can you point out which change fixed this if you already know? |
HyukjinKwon
approved these changes
Jun 4, 2020
|
@HyukjinKwon I guess this PR fixes the issue mainly: |
|
Test build #123519 has finished for PR 28723 at commit
|
|
Let's cut out RC3 first and then merge. |
maropu
approved these changes
Jun 4, 2020
cloud-fan
reviewed
Jun 5, 2020
| @@ -68,8 +68,6 @@ class ThriftServerQueryTestSuite extends SQLQueryTestSuite with SharedThriftServ | |||
| // Missing UDF | |||
| "postgreSQL/boolean.sql", | |||
| "postgreSQL/case.sql", | |||
| // SPARK-28624 | |||
| "date.sql", | |||
There was a problem hiding this comment.
thriftserver doesn't support negative year, I think we still need to ignore this test.
|
I discussed with @MaxGekk @cloud-fan. The tests will have to be disabled back at SPARK-30808. Basically, resulting to We strictly can just merge and enable it for Spark 3.0 specifically because SPARK-30808 won't land to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable
date.sqland run it via Thrift Server inThriftServerQueryTestSuite.Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the enabled tests via: