Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite #28782

Closed
wants to merge 17 commits into from
Closed

[SPARK-31954][SQL] Delete duplicate testcase in HiveQuerySuite #28782

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bb1efa2
Merge pull request #1 from apache/master
GuoPhilipse May 20, 2020
1459d5b
Merge pull request #2 from apache/master
GuoPhilipse May 22, 2020
88c40fe
Merge pull request #3 from apache/master
GuoPhilipse May 22, 2020
df22083
Merge pull request #4 from apache/master
GuoPhilipse May 25, 2020
0436611
Merge pull request #5 from apache/master
GuoPhilipse May 27, 2020
ed80c84
Merge pull request #6 from apache/master
GuoPhilipse May 27, 2020
39ca87c
Merge pull request #7 from apache/master
GuoPhilipse May 28, 2020
c3b3c89
Merge pull request #8 from apache/master
GuoPhilipse May 28, 2020
c3546eb
Merge pull request #9 from apache/master
GuoPhilipse Jun 2, 2020
77a339a
Merge pull request #10 from apache/master
GuoPhilipse Jun 3, 2020
a6b4f74
Merge pull request #11 from apache/master
GuoPhilipse Jun 5, 2020
664277e
Merge pull request #12 from apache/master
GuoPhilipse Jun 7, 2020
fd677c9
Merge pull request #13 from apache/master
GuoPhilipse Jun 8, 2020
93b1f63
Merge pull request #14 from apache/master
GuoPhilipse Jun 10, 2020
c4f9a62
remove duplicate test cases
GuoPhilipse Jun 10, 2020
0eec8ff
rename test case result and adjust test case order
GuoPhilipse Jun 11, 2020
c7b81d2
delete useless file
GuoPhilipse Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sql/hive/src/test/resources/golden/timestamp cast #4-0-732ed232ac592c5e7f7c913a88874fd2
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion sql/hive/src/test/resources/golden/timestamp cast #8-0-6d2da5cfada03605834e38bc4075bc79
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,9 +564,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(1200 == res.getInt(0))
}

createQueryTest("timestamp cast #4",
"SELECT CAST(CAST(1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, as you suggested, the test looks duplicate. cc: @HyukjinKwon @viirya

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks duplicate.


test("timestamp cast #5") {
val res = sql("SELECT CAST(CAST(-1 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1").collect().head
assert(-1 == res.get(0))
Expand All @@ -580,9 +577,6 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
assert(-1200 == res.getInt(0))
}

createQueryTest("timestamp cast #8",
"SELECT CAST(CAST(-1.2 AS TIMESTAMP) AS DOUBLE) FROM src LIMIT 1")

Comment on lines -583 to -585
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing them, maybe we can change them? As you see that these tests are with numbers (#4 and #8), removing them makes the numbers not continuous now. Not strongly option, anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can rename them to make it prettier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

createQueryTest("select null from table",
"SELECT null FROM src LIMIT 1")

Expand Down