Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression #28808

Closed
wants to merge 8 commits into from
Closed

[SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression #28808

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f283385
init
ulysses-you Jun 12, 2020
38df40a
typo
ulysses-you Jun 12, 2020
cd8bbb2
update msg
ulysses-you Jun 12, 2020
335935f
typo
ulysses-you Jun 13, 2020
458d457
Merge branch 'master' of https://github.com/apache/spark into SPARK-3…
ulysses-you Jul 2, 2020
972ae13
nit
ulysses-you Jul 2, 2020
0798fca
check all expression
ulysses-you Jul 3, 2020
3e116f5
nit
ulysses-you Jul 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")

case Alias(w: WindowFunction, _) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW why do we have to match the Alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right way is Alias(WindowExpression(w: WindowFunction, _), _) and without over it is Alias(w: WindowFunction, _).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then the check doesn't work for cases like rank() + 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch ! we need to check all expression.

failAnalysis(s"Window function $w call requires an OVER clause.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can remove call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.


case w @ WindowExpression(AggregateExpression(_, _, true, _, _), _) =>
failAnalysis(s"Distinct window functions are not supported: $w")

Expand Down
5 changes: 5 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,4 +826,9 @@ class AnalysisSuite extends AnalysisTest with Matchers {
}
}
}

test("throw user facing error when use WindowFunction directly") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a JIRA prefix here? SPARK-31975: ...

assertAnalysisError(testRelation2.select(RowNumber()),
Seq("Window function row_number() call requires an OVER clause."))
}
}