Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4168][WebUI] web statges number should show correctly when stages are more than 1000 #3035

Closed
wants to merge 3 commits into from

Conversation

liyezhang556520
Copy link
Contributor

The number of completed stages and failed stages showed on webUI will always be less than 1000. This is really misleading when there are already thousands of stages completed or failed. The number should be correct even when only partial stages listed on the webUI (stage info will be removed if the number is too large).

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22608 has started for PR 3035 at commit f4c404d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22608 has finished for PR 3035 at commit f4c404d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22608/
Test PASSed.

// Number of completed stages, not equal to completedStages.size
var completedStagesNum = 0
// number of failed stages, not equal to failedStagesNum.size
var failedStagesNum = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to call these numFailedStages

@SparkQA
Copy link

SparkQA commented Nov 1, 2014

Test build #22679 has started for PR 3035 at commit 4ea8fd1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 1, 2014

Test build #22679 has finished for PR 3035 at commit 4ea8fd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22679/
Test PASSed.

@liyezhang556520
Copy link
Contributor Author

@andrewor14 , sorry to misunderstand. the comments updated, can you have a look to see if it is ok?

@SparkQA
Copy link

SparkQA commented Nov 2, 2014

Test build #22717 has started for PR 3035 at commit d9e29fb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 2, 2014

Test build #22717 has finished for PR 3035 at commit d9e29fb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22717/
Test PASSed.

@liyezhang556520
Copy link
Contributor Author

@andrewor14 , can you help to check whether this patch is fine now?

@andrewor14
Copy link
Contributor

Yeah LGTM I'll merge this.

@asfgit asfgit closed this in 97a466e Nov 4, 2014
@liyezhang556520 liyezhang556520 deleted the webStageNum branch November 4, 2014 14:35
asfgit pushed a commit that referenced this pull request Nov 5, 2014
…ges are more than 1000

The number of completed stages and failed stages showed on webUI will always be less than 1000. This is really misleading when there are already thousands of stages completed or failed. The number should be correct even when only partial stages listed on the webUI (stage info will be removed if the number is too large).

Author: Zhang, Liye <liye.zhang@intel.com>

Closes #3035 from liyezhang556520/webStageNum and squashes the following commits:

d9e29fb [Zhang, Liye] add detailed comments for variables
4ea8fd1 [Zhang, Liye] change variable name accroding to comments
f4c404d [Zhang, Liye] [SPARK-4168][WebUI] web statges number should show correctly when stages are more than 1000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants