fixed MLlib Naive-Bayes java example bug #3081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -90,7 +90,7 @@ JavaPairRDD<Double, Double> predictionAndLabel = | |||
| }); | |||
| double accuracy = 1.0 * predictionAndLabel.filter(new Function<Tuple2<Double, Double>, Boolean>() { | |||
| @Override public Boolean call(Tuple2<Double, Double> pl) { | |||
| return pl._1() == pl._2(); | |||
| return pl._1().doubleValue() == pl._2().doubleValue(); | |||
There was a problem hiding this comment.
Is pl._1().equals(pl._2()) better?
There was a problem hiding this comment.
Yeah kinda. Also would the esteemed author indulge me and remove 1.0 * in favor of an actual cast or .doubleValue() as well?
|
there you go, looks more elegant now |
|
LGTM. I've merged this into master and branch-1.2 (skipped Jenkins because it only contains doc change). Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2014
the filter tests Double objects by references whereas it should test their values Author: Dariusz Kobylarz <darek.kobylarz@gmail.com> Closes #3081 from dkobylarz/master and squashes the following commits: 5d43a39 [Dariusz Kobylarz] naive bayes example update a304b93 [Dariusz Kobylarz] fixed MLlib Naive-Bayes java example bug (cherry picked from commit bcecd73) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the filter tests Double objects by references whereas it should test their values