Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4421] Wrong link in spark-standalone.html #3280

Closed
wants to merge 1 commit into from

Conversation

tsudukim
Copy link
Contributor

Modified the link of building Spark. (backport version of #3279.)

Modified the link of building Spark. (backport version of apache#3279.)
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@tsudukim
Copy link
Contributor Author

I sent 2 PRs about SPARK-4421 because the page name are different between Spark 1.2 and Spark 1.1.
This is for Spark 1.1.

@srowen
Copy link
Member

srowen commented Nov 15, 2014

@tsudukim I think the practice is always to open a PR for master, not branches. The patch will be back-ported as appropriate. Could you change your PRs into one for master?

@tsudukim
Copy link
Contributor Author

Thank you @srowen for following this ticket.
I know PR should be for master generally, and I already sent one for master (#3279).
But the details of modification for master and for branch-1.1 are different because the filename in master was changed from branch-1.1, so i thought branch-1.1 requires another PR and sent this (#3280).
If you don't need this PR, I will just close it.

@srowen
Copy link
Member

srowen commented Nov 16, 2014

That makes sense. I don't know if it is better to leave this or let the merger apply this change when it is applied to 1.1. It may not be worth it since docs are made from the latest release. Let them decide.

@JoshRosen
Copy link
Contributor

LGTM; I'm going to merge this into branch-1.1. GitHub won't automatically close PRs via commit messages if those PRs aren't made against the master branch, so do you mind closing this yourself? Thanks!

asfgit pushed a commit that referenced this pull request Dec 5, 2014
Modified the link of building Spark. (backport version of #3279.)

Author: Masayoshi TSUZUKI <tsudukim@oss.nttdata.co.jp>

Closes #3280 from tsudukim/feature/SPARK-4421-2 and squashes the following commits:

3b4d38d [Masayoshi TSUZUKI] [SPARK-4421] Wrong link in spark-standalone.html
@tsudukim
Copy link
Contributor Author

tsudukim commented Dec 5, 2014

Thank you! @JoshRosen

@tsudukim tsudukim closed this Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants