[SPARK-4468][SQL] Fixes Parquet filter creation for inequality predicates with literals on the left hand side #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #23532 has started for PR 3334 at commit
|
liancheng
changed the title
|
Marked this PR as WIP as there might be another NPE issue inherited from the original code. |
liancheng
changed the title
|
OK, removed the WIP tag, since it may take some time to look into the other issue while this bug is somewhat critical as it affects query result correctness. @marmbrus This should be ready to go once Jenkins says yes. Will open another PR to tackle the possible NPE issue. |
|
Test build #23532 has finished for PR 3334 at commit
|
|
Test PASSed. |
liancheng
added a commit
to liancheng/spark
that referenced
this pull request
Nov 18, 2014
marmbrus
pushed a commit
to marmbrus/spark
that referenced
this pull request
Nov 19, 2014
…ates with literals on the left hand side For expressions like `10 < someVar`, we should create an `Operators.Gt` filter, but right now an `Operators.Lt` is created. This issue affects all inequality predicates with literals on the left hand side. (This bug existed before apache#3317 and affects branch-1.1. apache#3338 was opened to backport this to branch-1.1.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3334) <!-- Reviewable:end --> Author: Cheng Lian <lian@databricks.com> Closes apache#3334 from liancheng/fix-parquet-comp-filter and squashes the following commits: 0130897 [Cheng Lian] Fixes Parquet comparison filter generation
liancheng
added a commit
that referenced
this pull request
Nov 19, 2014
…ates with literals on the left hand side For expressions like `10 < someVar`, we should create an `Operators.Gt` filter, but right now an `Operators.Lt` is created. This issue affects all inequality predicates with literals on the left hand side. (This bug existed before #3317 and affects branch-1.1. #3338 was opened to backport this to branch-1.1.) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3334) <!-- Reviewable:end --> Author: Cheng Lian <lian@databricks.com> Closes #3334 from liancheng/fix-parquet-comp-filter and squashes the following commits: 0130897 [Cheng Lian] Fixes Parquet comparison filter generation (cherry picked from commit 423baea) Signed-off-by: Michael Armbrust <michael@databricks.com>
|
This PR has already been merged, status not updated 'cause the out-of-sync issue between GitHub and ASF repo. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For expressions like
10 < someVar, we should create anOperators.Gtfilter, but right now anOperators.Ltis created. This issue affects all inequality predicates with literals on the left hand side.(This bug existed before #3317 and affects branch-1.1. #3338 was opened to backport this to branch-1.1.)