-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-1434] [MLLIB] change labelParser from anonymous function to trait #345
Changes from 2 commits
7f8eb36
11c94e0
c2e571c
3b1a7c6
ac44409
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.mllib.util | ||
|
||
/** Trait for label parsers. */ | ||
trait LabelParser extends Serializable { | ||
/** Parses a string label into a double label. */ | ||
def apply(labelString: String): Double | ||
} | ||
|
||
/** | ||
* Label parser for binary labels, which outputs 1.0 (positive) if the value is greater than 0.5, | ||
* or 0.0 (negative) otherwise. So it works with +1/-1 labeling and +1/0 labeling. | ||
*/ | ||
class BinaryLabelParser extends LabelParser { | ||
/** | ||
* Parses the input label into positive (1.0) if the value is greater than 0.5, | ||
* or negative (0.0) otherwise. | ||
*/ | ||
override def apply(labelString: String): Double = if (labelString.toDouble > 0.5) 1.0 else 0.0 | ||
} | ||
|
||
object BinaryLabelParser { | ||
private lazy val instance = new BinaryLabelParser() | ||
/** Gets the default instance of BinaryLabelParser. */ | ||
def apply(): BinaryLabelParser = instance | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You don't need this, you could just do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is much better. |
||
} | ||
|
||
/** | ||
* Label parser for multiclass labels, which converts the input label to double. | ||
*/ | ||
class MulticlassLabelParser extends LabelParser { | ||
override def apply(labelString: String): Double = labelString.toDouble | ||
} | ||
|
||
object MulticlassLabelParser { | ||
private lazy val instance = new MulticlassLabelParser() | ||
/** Gets the default instance of MulticlassLabelParser. */ | ||
def apply(): MulticlassLabelParser = instance | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto on just having an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call this
parse
instead ofapply
, should be friendlierThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.