Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][SPARK-37359][K8S] Cleanup the Spark Kubernetes Integration tests #34636

Closed

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Nov 17, 2021

What changes were proposed in this pull request?

Drop remove reason stats check to make the test less flaky & disable Spark R test [hasn't passed for a long time]
Try and avoid PV/PVC delete/create race condition

Why are the changes needed?

Or K8s test suite is broken so people ignore it. This is not good.

Listener bus message is not always delivered and printed
SparkR tests have been broken for a long time and I don't see any interest in fixing them
PV/PVC creation/deletion can have a race condition during integration tests.

Does this PR introduce any user-facing change?

Test only change

How was this patch tested?

WIP (waiting on CI for k8s int).

@holdenk holdenk changed the title [WIP][SPARK-37359][K8S] Drop remove reason stats check to make the test less flaky [WIP][SPARK-37359][K8S] Drop remove reason stats check to make the test less flaky & disable Spark R test [hasn't passed for a long time] Nov 17, 2021
@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Test build #145348 has finished for PR 34636 at commit 71d7bf4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49819/

@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49819/

@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Test build #145349 has finished for PR 34636 at commit bee9d63.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk holdenk force-pushed the SPARK-37359-spark-k8s-decom-test-string branch from bee9d63 to a73b27c Compare November 17, 2021 21:53
@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49820/

@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49820/

@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Test build #145351 has finished for PR 34636 at commit a73b27c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 17, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49822/

@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49822/

@holdenk holdenk changed the title [WIP][SPARK-37359][K8S] Drop remove reason stats check to make the test less flaky & disable Spark R test [hasn't passed for a long time] [WIP][SPARK-37359][K8S] Cleanup the Spark Kubernetes Integration tests Nov 18, 2021
@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Test build #145400 has finished for PR 34636 at commit 12a4096.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49873/

@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49873/

@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Test build #145404 has finished for PR 34636 at commit e1e61f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49877/

@SparkQA
Copy link

SparkQA commented Nov 18, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49877/

@SparkQA
Copy link

SparkQA commented Nov 22, 2021

Test build #145520 has finished for PR 34636 at commit 14022c0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 22, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49992/

@SparkQA
Copy link

SparkQA commented Nov 22, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49992/

@Yikun
Copy link
Member

Yikun commented Dec 20, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Dec 20, 2021

Test build #146393 has finished for PR 34636 at commit 14022c0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50868/

@SparkQA
Copy link

SparkQA commented Dec 20, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50868/

@holdenk
Copy link
Contributor Author

holdenk commented Mar 16, 2022

Closed for now we can revisit this later when we re-enable K8s testing.

@holdenk holdenk closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants