-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-4613][Core] Java API for JdbcRDD #3478
Conversation
Test build #23888 has started for PR 3478 at commit
|
Test build #23888 has finished for PR 3478 at commit
|
Test FAILed. |
@liancheng this appears to have failed its own test :P |
@pwendell Yea, I don't see why it can't find Derby driver, and I can't reproduce it locally :( |
Maybe it got it from the Java or Hadoop version. You can add a test dep on Derby. |
Test build #23912 has started for PR 3478 at commit
|
@mateiz The thing puzzles me is that Derby has already been added as a test dependency in Spark core, otherwise the Scala |
Test build #23912 has finished for PR 3478 at commit
|
Test FAILed. |
Found the cause. |
Test build #23917 has started for PR 3478 at commit
|
Test build #23917 has finished for PR 3478 at commit
|
Test PASSed. |
Looks good to me; going to merge it. |
This PR introduces a set of Java APIs for using `JdbcRDD`: 1. Trait (interface) `JdbcRDD.ConnectionFactory`: equivalent to the `getConnection: () => Connection` parameter in `JdbcRDD` constructor. 2. Two overloaded versions of `Jdbc.create`: used to create `JavaRDD` that wraps a `JdbcRDD`. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3478) <!-- Reviewable:end --> Author: Cheng Lian <lian@databricks.com> Closes #3478 from liancheng/japi-jdbc-rdd and squashes the following commits: 9a54625 [Cheng Lian] Only shutdowns a single DB rather than the whole Derby driver d4cedc5 [Cheng Lian] Moves Java JdbcRDD test case to a separate test suite ffcdf2e [Cheng Lian] Java API for JdbcRDD (cherry picked from commit 120a350) Signed-off-by: Matei Zaharia <matei@databricks.com>
This PR introduces a set of Java APIs for using
JdbcRDD
:JdbcRDD.ConnectionFactory
: equivalent to thegetConnection: () => Connection
parameter inJdbcRDD
constructor.Jdbc.create
: used to createJavaRDD
that wraps aJdbcRDD
.