Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37934] [Build] Upgrade Jetty version to 9.4.44 #35230

Closed
wants to merge 2 commits into from

Conversation

this
Copy link
Contributor

@this this commented Jan 17, 2022

What changes were proposed in this pull request?

This PR upgrades Jetty version to 9.4.44.v20210927.

Why are the changes needed?

We would like to have the fix for jetty/jetty.project#6973 in latest Spark.

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI

@github-actions github-actions bot added the BUILD label Jan 17, 2022
@this this force-pushed the upgrade-jetty-9.4.44 branch from 91dce23 to e002d68 Compare January 17, 2022 15:19
@srowen
Copy link
Member

srowen commented Jan 17, 2022

I think you need to run the dev/test-dependencies.sh --replace-manifest script

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Jan 19, 2022

Hm. The tests fail for unrelated reasons (can't download some library?), and I tried re-running them, but seems like the same result. Eh, hm, does anyone else know how to kick this properly?

@HyukjinKwon
Copy link
Member

Ah, only the PR author can kick the build at https://github.com/this/spark/runs/4844562933 .. one workaround for committers is to manually push an empty commit. this is the limitation in the current CI implementation 😢

@this
Copy link
Contributor Author

this commented Jan 19, 2022

FYI I have restarted the build job.

@this
Copy link
Contributor Author

this commented Jan 19, 2022

My 3rd attempted passed https://github.com/this/spark/runs/4869742406?check_suite_focus=true. However that is not reflected here in the checks list. Do I need to push an empty commit to re-trigger a new build or is this enough?

@srowen
Copy link
Member

srowen commented Jan 19, 2022

Yep all green now. I will merge to master

@srowen srowen closed this in 2e95c6f Jan 19, 2022
@this
Copy link
Contributor Author

this commented Jan 19, 2022

@srowen Do we need to port this to the branch-3.2branch?

@srowen
Copy link
Member

srowen commented Jan 19, 2022

Possible, how much does this affect spark users? Generally wouldn't back port anything but non trivial bug fixes

@this
Copy link
Contributor Author

this commented Jan 21, 2022

Possible, how much does this affect spark users? Generally wouldn't back port anything but non trivial bug fixes

@srowen Not much, Ack.

@JackBuggins
Copy link

@srowen @this I would certainly pick up this update if it was made available against branch-3.2. Are there any strong objections to me raising a PR for it?

@HyukjinKwon
Copy link
Member

Is there any significant bug that affects Spark directly?

@JackBuggins
Copy link

None to my knowledge @HyukjinKwon, but wrt jetty/jetty.project#6973, my thinking is it would offer peace of mind

@dongjoon-hyun
Copy link
Member

In general, the dependency change on the release branch is -1 by default if there is no significant needs, @JackBuggins .

None to my knowledge @HyukjinKwon, but wrt eclipse/jetty.project#6973, my thinking is it would offer peace of mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants