-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-37934] [Build] Upgrade Jetty version to 9.4.44 #35230
Conversation
91dce23
to
e002d68
Compare
I think you need to run the |
Can one of the admins verify this patch? |
Hm. The tests fail for unrelated reasons (can't download some library?), and I tried re-running them, but seems like the same result. Eh, hm, does anyone else know how to kick this properly? |
Ah, only the PR author can kick the build at https://github.com/this/spark/runs/4844562933 .. one workaround for committers is to manually push an empty commit. this is the limitation in the current CI implementation 😢 |
FYI I have restarted the build job. |
My 3rd attempted passed https://github.com/this/spark/runs/4869742406?check_suite_focus=true. However that is not reflected here in the checks list. Do I need to push an empty commit to re-trigger a new build or is this enough? |
Yep all green now. I will merge to master |
@srowen Do we need to port this to the |
Possible, how much does this affect spark users? Generally wouldn't back port anything but non trivial bug fixes |
@srowen Not much, Ack. |
Is there any significant bug that affects Spark directly? |
None to my knowledge @HyukjinKwon, but wrt jetty/jetty.project#6973, my thinking is it would offer peace of mind |
In general, the dependency change on the release branch is -1 by default if there is no significant needs, @JackBuggins .
|
What changes were proposed in this pull request?
This PR upgrades Jetty version to
9.4.44.v20210927
.Why are the changes needed?
We would like to have the fix for jetty/jetty.project#6973 in latest Spark.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI