Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4685] Update JavaDoc settings to include spark.ml and all spark.m... #3554

Closed
wants to merge 1 commit into from
Closed

[SPARK-4685] Update JavaDoc settings to include spark.ml and all spark.m... #3554

wants to merge 1 commit into from

Conversation

Lewuathe
Copy link
Contributor

@Lewuathe Lewuathe commented Dec 2, 2014

...llib subpackages in the right sections

Create subcategory, MLlib and ML for correspond packages.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@sryza
Copy link
Contributor

sryza commented Dec 2, 2014

Does this require any corresponding change in the Maven build?

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Dec 2, 2014

@sryza There is no other additional process. You can build documents with below instruction.
https://github.com/apache/spark/blob/master/docs/README.md

@mengxr
Copy link
Contributor

mengxr commented Dec 3, 2014

@Lewuathe Thanks for taking care of the docs! Since spark.ml is a preview of the new APIs for the 1.2 release, do you mind put ml.* under the MLlib group instead of ML? Once it becomes more mature, we can make a separate section for it.

@mengxr
Copy link
Contributor

mengxr commented Dec 3, 2014

ok to test

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24094 has started for PR 3554 at commit f7535e6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24094 has finished for PR 3554 at commit f7535e6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24094/
Test FAILed.

@mengxr mengxr mentioned this pull request Dec 4, 2014
Closed
@mengxr
Copy link
Contributor

mengxr commented Dec 4, 2014

@Lewuathe Since we are cutting a RC soon, I created a new PR with the suggested change: #3598

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Dec 4, 2014

@mengxr Sorry for being late for response. Thank you.

asfgit pushed a commit that referenced this pull request Dec 4, 2014
@Lewuathe @mengxr
[SPARK-4685] Include all spark.ml and spark.mllib packages in JavaDoc…
2605acb 
…'s MLlib group

This is #3554 from Lewuathe except that I put both `spark.ml` and `spark.mllib` in the group 'MLlib`.

Closes #3554

jkbradley

Author: lewuathe <lewuathe@me.com>
Author: Xiangrui Meng <meng@databricks.com>

Closes #3598 from mengxr/Lewuathe-modify-javadoc-setting and squashes the following commits:

184609a [Xiangrui Meng] merge spark.ml and spark.mllib into the same group in javadoc
f7535e6 [lewuathe] [SPARK-4685] Update JavaDoc settings to include spark.ml and all spark.mllib subpackages in the right sections

(cherry picked from commit 20bfea4)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 20bfea4 Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lewuathe @AmplabJenkins @sryza @mengxr @SparkQA