[SPARK-4821] [mllib] [python] [docs] Fix for pyspark.mllib.rand doc #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude edit to make IntelliJ happy.
|
CC: @pwendell This fixes a problem with missing documentation in the current build (and in branch-1.2). |
| @@ -36,10 +36,10 @@ pyspark.mllib.linalg module | |||
| :undoc-members: | |||
| :show-inheritance: | |||
|
|
|||
| pyspark.mllib.random module | |||
| pyspark.mllib.rand module | |||
There was a problem hiding this comment.
I think we still use random as the public module name, rand is only used internal.
There was a problem hiding this comment.
It could be fixed by
diff --git a/python/pyspark/mllib/__init__.py b/python/pyspark/mllib/__init__.py
index 5030a65..cba540a 100644
--- a/python/pyspark/mllib/__init__.py
+++ b/python/pyspark/mllib/__init__.py
@@ -32,7 +32,7 @@ import sys
import rand as random
random.__name__ = 'random'
random.RandomRDDs.__module__ = __name__ + '.random'
+sys.modules[__name__ + '.random'] = random
class RandomModuleHook(object):
"""
|
@davies Thanks very much! Updated. I made a separate JIRA for fixing Python doc annotations: |
|
That last commit fixes a doc build warning: |
|
Test build #24325 has finished for PR 3669 at commit
|
|
Test build #24331 has finished for PR 3669 at commit
|
|
Test build #24330 has finished for PR 3669 at commit
|
|
LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Dec 17, 2014
+ small doc edit + include edit to make IntelliJ happy CC: davies mengxr Note to davies -- this does not fix the "WARNING: Literal block expected; none found." warnings since that seems to involve spacing which IntelliJ does not like. (Those warnings occur when generating the Python docs.) Author: Joseph K. Bradley <joseph@databricks.com> Closes #3669 from jkbradley/python-warnings and squashes the following commits: 4587868 [Joseph K. Bradley] fixed warning 8cb073c [Joseph K. Bradley] Updated based on davies recommendation c51eca4 [Joseph K. Bradley] Updated rst file for pyspark.mllib.rand doc. Small doc edit. Small include edit to make IntelliJ happy. (cherry picked from commit affc3f4) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
Merged into master and branch-1.2. Thanks! |
JoshRosen
pushed a commit
to JoshRosen/spark
that referenced
this pull request
Jan 12, 2015
+ small doc edit + include edit to make IntelliJ happy CC: davies mengxr Note to davies -- this does not fix the "WARNING: Literal block expected; none found." warnings since that seems to involve spacing which IntelliJ does not like. (Those warnings occur when generating the Python docs.) Author: Joseph K. Bradley <joseph@databricks.com> Closes apache#3669 from jkbradley/python-warnings and squashes the following commits: 4587868 [Joseph K. Bradley] fixed warning 8cb073c [Joseph K. Bradley] Updated based on davies recommendation c51eca4 [Joseph K. Bradley] Updated rst file for pyspark.mllib.rand doc. Small doc edit. Small include edit to make IntelliJ happy. Conflicts: python/docs/pyspark.streaming.rst python/pyspark/mllib/feature.py
asfgit
pushed a commit
that referenced
this pull request
Jan 13, 2015
…o branch-1.1 This backports #3216 and #3669 to `branch-1.1` in order to fix the PySpark unit tests. Author: Joseph K. Bradley <joseph@databricks.com> Author: Davies Liu <davies@databricks.com> Closes #4011 from JoshRosen/pyspark-rand-fix-1.1-backport and squashes the following commits: ace4cb6 [Joseph K. Bradley] [SPARK-4821] [mllib] [python] [docs] Fix for pyspark.mllib.rand doc 7ae5a1c [Davies Liu] [SPARK-4348] [PySpark] [MLlib] rename random.py to rand.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @davies @mengxr
Note to @davies -- this does not fix the "WARNING: Literal block expected; none found." warnings since that seems to involve spacing which IntelliJ does not like. (Those warnings occur when generating the Python docs.)