Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "--package" argument to make-distribution.sh #3682

Closed
wants to merge 2 commits into from

Conversation

jmschrack
Copy link

"--package" creates a distribution without building.
Added the above info to the README.md.

…bution without building.

Added the above info to the README.md.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

Hey @jmschrack - I'm not sure we want to allow packaging without building in this script. This allows for some confusing outcomes, such as a user compiles Spark for one version, then they call make-distribution with different maven flags, and the naming of the distribution and notes are inconsistent with the actual binaries. Since make-distribution takes identical flags to the build, I'd rather just force people to build and package atomically. So I'd prefer to close this issue for now and feel free to re-open if you'd like to discuss further.

@asfgit asfgit closed this in e12b5b6 Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants