[SPARK-38018][SQL][3.2] Fix ColumnVectorUtils.populate to handle CalendarIntervalType correctly #37114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still waiting for the test results, but cc @cloud-fan and @dongjoon-hyun if you have time to take a look, thanks! |
cloud-fan
approved these changes
Jul 7, 2022
|
tests all passed, but the reporting is broken: https://github.com/c21/spark/actions/runs/2627811518 |
cloud-fan
pushed a commit
that referenced
this pull request
Jul 7, 2022
…ndarIntervalType correctly ### What changes were proposed in this pull request? This is a backport of #35314 to branch 3.2. See that original PR for context. ### Why are the changes needed? To fix potential correctness issue. ### Does this PR introduce _any_ user-facing change? No but fix the exiting correctness issue when reading partition column with CalendarInterval type. ### How was this patch tested? Added unit test in `ColumnVectorSuite.scala`. Closes #37114 from c21/branch-3.2. Authored-by: Cheng Su <scnju13@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
thanks, merging to 3.2 |
|
Thank you all for review! |
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
…ndarIntervalType correctly ### What changes were proposed in this pull request? This is a backport of apache#35314 to branch 3.2. See that original PR for context. ### Why are the changes needed? To fix potential correctness issue. ### Does this PR introduce _any_ user-facing change? No but fix the exiting correctness issue when reading partition column with CalendarInterval type. ### How was this patch tested? Added unit test in `ColumnVectorSuite.scala`. Closes apache#37114 from c21/branch-3.2. Authored-by: Cheng Su <scnju13@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c5983c1) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a backport of #35314 to branch 3.2. See that original PR for context.
Why are the changes needed?
To fix potential correctness issue.
Does this PR introduce any user-facing change?
No but fix the exiting correctness issue when reading partition column with CalendarInterval type.
How was this patch tested?
Added unit test in
ColumnVectorSuite.scala.