Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4880] remove spark.locality.wait in Analytics #3730

Closed
wants to merge 1 commit into from
Closed

[SPARK-4880] remove spark.locality.wait in Analytics #3730

wants to merge 1 commit into from

Conversation

Earne
Copy link
Contributor

@Earne Earne commented Dec 18, 2014

spark.locality.wait set to 100000 in examples/graphx/Analytics.scala.
Should be left to the user.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@ankurdave
Copy link
Contributor

ok to test

@ankurdave
Copy link
Contributor

Thanks. This is a remnant from a serialization bug that GraphX used to have but was fixed a while ago, so there's no reason to set the locality wait anymore.

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24572 has started for PR 3730 at commit d79ed04.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24572 has finished for PR 3730 at commit d79ed04.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24572/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Dec 18, 2014

LGTM. Merging in master & branch-1.2. Thanks!

@asfgit asfgit closed this in a7ed6f3 Dec 18, 2014
asfgit pushed a commit that referenced this pull request Dec 18, 2014
@Earne @rxin
[SPARK-4880] remove spark.locality.wait in Analytics
e7f9dd5 
spark.locality.wait set to 100000 in examples/graphx/Analytics.scala.
Should be left to the user.

Author: Ernest <earneyzxl@gmail.com>

Closes #3730 from Earne/SPARK-4880 and squashes the following commits:

d79ed04 [Ernest] remove spark.locality.wait in Analytics

(cherry picked from commit a7ed6f3)
Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Earne @AmplabJenkins @ankurdave @SparkQA @rxin