-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-4920][UI]:current spark version in UI is not striking. #3763
Conversation
Test build #24705 has started for PR 3763 at commit
|
Test build #24705 has finished for PR 3763 at commit
|
Test PASSed. |
+1. I also thought the bottom greyed out text is too obscure. @JoshRosen any thoughts? |
@srowen commented on the JIRA:
I prefer the CSS in this PR, but I also worry about long SNAPSHOT versions. That said, maybe it's not a huge deal on common screen resolutions. |
By the way, if we merge this it should also go into |
Meh, on looking at it again, I like the new version that's consistent with the website. It's only devs that will look at long SNAPSHOT names. It's a clean change too. |
Alright, sounds good then I'm going to merge this into master 1.2 thanks guys. |
It is not convenient to see the Spark version. We can keep the same style with Spark website. ![spark_version](https://cloud.githubusercontent.com/assets/7402327/5527025/1c8c721c-8a35-11e4-8d6a-2734f3c6bdf8.jpg) Author: genmao.ygm <genmao.ygm@alibaba-inc.com> Closes #3763 from uncleGen/master-clean-141222 and squashes the following commits: 0dcb9a9 [genmao.ygm] [SPARK-4920][UI]:current spark version in UI is not striking. (cherry picked from commit de9d7d2) Signed-off-by: Andrew Or <andrew@databricks.com>
@andrewor14 would you mind merging this into |
@ash211 I think that Andrew tried this, but there was a merge conflict:
|
Oh whoops my apologies for the noise |
Branch-1.1 backport is here: #3768 |
It is not convenient to see the Spark version. We can keep the same style with Spark website.