Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4920][UI]:current spark version in UI is not striking. #3763

Closed
wants to merge 1 commit into from

Conversation

uncleGen
Copy link
Contributor

It is not convenient to see the Spark version. We can keep the same style with Spark website.

spark_version

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24705 has started for PR 3763 at commit 0dcb9a9.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 22, 2014

Test build #24705 has finished for PR 3763 at commit 0dcb9a9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24705/
Test PASSed.

@andrewor14
Copy link
Contributor

+1. I also thought the bottom greyed out text is too obscure. @JoshRosen any thoughts?

@JoshRosen
Copy link
Contributor

@srowen commented on the JIRA:

I slight prefer the current UI, where the version is in the footer. Putting the version here pushes the tabs right significantly when the version is the long "1.3.0-SNAPSHOT". That said it is consistent with the web site. I imagine the necessary CSS is simple if they are both Bootstrap-based.

I prefer the CSS in this PR, but I also worry about long SNAPSHOT versions. That said, maybe it's not a huge deal on common screen resolutions.

@JoshRosen
Copy link
Contributor

By the way, if we merge this it should also go into branch-1.1.

@srowen
Copy link
Member

srowen commented Dec 22, 2014

Meh, on looking at it again, I like the new version that's consistent with the website. It's only devs that will look at long SNAPSHOT names. It's a clean change too.

@andrewor14
Copy link
Contributor

Alright, sounds good then I'm going to merge this into master 1.2 thanks guys.
For 1.1, it appears that there is a non-trivial merge conflict. @uncleGen would you mind opening a PR to back port this patch to branch 1.1? Thanks.

asfgit pushed a commit that referenced this pull request Dec 22, 2014
It is not convenient to see the Spark version. We can keep the same style with Spark website.

![spark_version](https://cloud.githubusercontent.com/assets/7402327/5527025/1c8c721c-8a35-11e4-8d6a-2734f3c6bdf8.jpg)

Author: genmao.ygm <genmao.ygm@alibaba-inc.com>

Closes #3763 from uncleGen/master-clean-141222 and squashes the following commits:

0dcb9a9 [genmao.ygm] [SPARK-4920][UI]:current spark version in UI is not striking.

(cherry picked from commit de9d7d2)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in de9d7d2 Dec 22, 2014
@ash211
Copy link
Contributor

ash211 commented Dec 23, 2014

@andrewor14 would you mind merging this into branch-1.1 also? @JoshRosen pointed out it should go there too

@JoshRosen
Copy link
Contributor

@ash211 I think that Andrew tried this, but there was a merge conflict:

For 1.1, it appears that there is a non-trivial merge conflict. @uncleGen would you mind opening a PR to back port this patch to branch 1.1? Thanks.

@ash211
Copy link
Contributor

ash211 commented Dec 23, 2014

Oh whoops my apologies for the noise

@JoshRosen
Copy link
Contributor

Branch-1.1 backport is here: #3768

@uncleGen uncleGen deleted the master-clean-141222 branch March 24, 2015 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants