[SPARK-39915][SQL][3.3] Dataset.repartition(N) may not create N partitions Non-AQE part #37730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Non-AQE part
Skip optimize the root user-specified repartition in `PropagateEmptyRelation`.
Spark should preserve the final repatition which can affect the final output partition which is user-specified.
For example:
```scala
spark.sql("select * from values(1) where 1 < rand()").repartition(1)
// before:
== Optimized Logical Plan ==
LocalTableScan <empty>, [col1#0]
// after:
== Optimized Logical Plan ==
Repartition 1, true
+- LocalRelation <empty>, [col1#0]
```
yes, the empty plan may change
add test
Closes apache#37706 from ulysses-you/empty.
Authored-by: ulysses-you <ulyssesyou18@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
cc @cloud-fan |
cloud-fan
approved these changes
Aug 30, 2022
dongjoon-hyun
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
+1, LGTM. Merged to branch-3.3.
Thank you, @ulysses-you and @cloud-fan .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 9, 2022
…tions Non-AQE part ### What changes were proposed in this pull request? backport #37706 for branch-3.3 Skip optimize the root user-specified repartition in `PropagateEmptyRelation`. ### Why are the changes needed? Spark should preserve the final repatition which can affect the final output partition which is user-specified. For example: ```scala spark.sql("select * from values(1) where 1 < rand()").repartition(1) // before: == Optimized Logical Plan == LocalTableScan <empty>, [col1#0] // after: == Optimized Logical Plan == Repartition 1, true +- LocalRelation <empty>, [col1#0] ``` ### Does this PR introduce _any_ user-facing change? yes, the empty plan may change ### How was this patch tested? add test Closes #37730 from ulysses-you/empty-3.3. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
thank you @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backport #37706 for branch-3.3
Skip optimize the root user-specified repartition in
PropagateEmptyRelation.Why are the changes needed?
Spark should preserve the final repatition which can affect the final output partition which is user-specified.
For example:
Does this PR introduce any user-facing change?
yes, the empty plan may change
How was this patch tested?
add test