Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARK-4660: Use correct default classloader in JavaSerializer. #3840

Closed
wants to merge 1 commit into from
Closed

SPARK-4660: Use correct default classloader in JavaSerializer. #3840

wants to merge 1 commit into from

Conversation

pkolaczk
Copy link

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

QA tests have started for PR 3840 at commit 86bc5eb.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

QA tests have finished for PR 3840 at commit 86bc5eb.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24907/
Test FAILed.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 5, 2015

QA tests have started for PR 3840 at commit 86bc5eb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 5, 2015

QA tests have finished for PR 3840 at commit 86bc5eb.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25059/
Test FAILed.

@pwendell
Copy link
Contributor

pwendell commented Jan 8, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

QA tests have started for PR 3840 at commit 86bc5eb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

QA tests have finished for PR 3840 at commit 86bc5eb.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25205/
Test FAILed.

@andrewor14
Copy link
Contributor

This seems to be failing from a known python imports issue in branch-1.1 not related to this patch.

@pwendell
Copy link
Contributor

pwendell commented Jan 8, 2015

@pkolaczk can you make a version of this pull request against the master branch?

@pkolaczk
Copy link
Author

pkolaczk commented Jan 9, 2015

Yes, I'll do.

@pwendell
Copy link
Contributor

@pkolaczk - any luck with the master PR

jacek-lewandowski added a commit to jacek-lewandowski/spark that referenced this pull request Jan 20, 2015
@jacek-lewandowski
SPARK-4660: Use correct class loader in JavaSerializer (copy of PR ap…
a5e84ca 
…ache#3840 by Piotr Kolaczkowski)
jacek-lewandowski added a commit to jacek-lewandowski/spark that referenced this pull request Jan 20, 2015
@jacek-lewandowski
SPARK-4660: Use correct class loader in JavaSerializer (copy of PR ap…
977c103 
…ache#3840 by Piotr Kolaczkowski)
@jacek-lewandowski
Copy link
Contributor

@pwendell here are pull requests for 1.2 and master branches respectively:
#4114
#4113

@pkolaczk is on vacation so he asked me to prepare these PRs

asfgit pushed a commit that referenced this pull request Jan 20, 2015
@jacek-lewandowski @pwendell
SPARK-4660: Use correct class loader in JavaSerializer (copy of PR #3840
692dc5b 
...

... by Piotr Kolaczkowski)

Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>

Closes #4113 from jacek-lewandowski/SPARK-4660-master and squashes the following commits:

a5e84ca [Jacek Lewandowski] SPARK-4660: Use correct class loader in JavaSerializer (copy of PR #3840 by Piotr Kolaczkowski)

(cherry picked from commit c93a57f)
Signed-off-by: Patrick Wendell <patrick@databricks.com>
asfgit pushed a commit that referenced this pull request Jan 20, 2015
@jacek-lewandowski @pwendell
SPARK-4660: Use correct class loader in JavaSerializer (copy of PR #3840
ecdeca0 
...

... by Piotr Kolaczkowski)

Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>

Closes #4113 from jacek-lewandowski/SPARK-4660-master and squashes the following commits:

a5e84ca [Jacek Lewandowski] SPARK-4660: Use correct class loader in JavaSerializer (copy of PR #3840 by Piotr Kolaczkowski)

(cherry picked from commit c93a57f)
Signed-off-by: Patrick Wendell <patrick@databricks.com>
asfgit pushed a commit that referenced this pull request Jan 20, 2015
@jacek-lewandowski @pwendell
SPARK-4660: Use correct class loader in JavaSerializer (copy of PR #3840
c93a57f 
...

... by Piotr Kolaczkowski)

Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>

Closes #4113 from jacek-lewandowski/SPARK-4660-master and squashes the following commits:

a5e84ca [Jacek Lewandowski] SPARK-4660: Use correct class loader in JavaSerializer (copy of PR #3840 by Piotr Kolaczkowski)
@pwendell
Copy link
Contributor

Okay I've merged this into all the relevant branches. Can you close this issue?

@jacek-lewandowski
Copy link
Contributor

I cannot, @pkolaczk can do this

bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 21, 2015
@jacek-lewandowski @bomeng
SPARK-4660: Use correct class loader in JavaSerializer (copy of PR ap…
d6a8d82 
…ache#3840...

... by Piotr Kolaczkowski)

Author: Jacek Lewandowski <lewandowski.jacek@gmail.com>

Closes apache#4113 from jacek-lewandowski/SPARK-4660-master and squashes the following commits:

a5e84ca [Jacek Lewandowski] SPARK-4660: Use correct class loader in JavaSerializer (copy of PR apache#3840 by Piotr Kolaczkowski)
@pkolaczk pkolaczk closed this Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pkolaczk @AmplabJenkins @JoshRosen @SparkQA @pwendell @andrewor14 @jacek-lewandowski