-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Fix import order and other coding style #3966
Conversation
Can one of the admins verify this patch? |
Jenkins, test this please. |
Test build #25304 has started for PR 3966 at commit
|
Test build #25304 has finished for PR 3966 at commit
|
Test FAILed. |
I think the stance has been to avoid one-off non-functional style changes for their own sake, as it buys almost nothing and costs time to review/test/resolve merge conflicts. If this were going to proceed, I would say you should also squash the ~20 commits here to one. |
@srowen this one might be ok since it is limited to a smaller scope - but I agree in general it is not a good idea to do massive style changes. When we merge, the merge script does automatic squash, so that it is not a huge problem here (but still would be nice if pr owners can squash for clarity in general). |
Ok, this one doesn't seem too invasive so I will go ahead and merge it in master. Thanks. |
fixed import order and other coding style