Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.3 #40430

Closed
wants to merge 13 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Mar 15, 2023

What changes were proposed in this pull request?

This pr aims upgrade protobuf-java from 3.22.0 to 3.22.3.

Why are the changes needed?

The new version fixed the issue of NoSuchMethodError thrown when using Java 8 to run proto compiled with Java 9+ (even if --target 1.8):

The full release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

@LuciferYang LuciferYang marked this pull request as draft March 15, 2023 02:58
@github-actions github-actions bot added the BUILD label Mar 15, 2023
@LuciferYang LuciferYang changed the title [SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.2 [WIP][SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.2 Mar 15, 2023
@LuciferYang LuciferYang changed the title [WIP][SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.2 [SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.2 Mar 15, 2023
@LuciferYang LuciferYang marked this pull request as ready for review March 15, 2023 05:14
@LuciferYang LuciferYang changed the title [SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.2 [SPARK-42798][BUILD] Upgrade protobuf-java to 3.22.3 Apr 17, 2023
@srowen
Copy link
Member

srowen commented Apr 23, 2023

Looks OK pending tests, but re-run tests

@LuciferYang
Copy link
Contributor Author

rebased and re-run tests, let's wait ci

@LuciferYang
Copy link
Contributor Author

All test passed

@srowen
Copy link
Member

srowen commented Apr 25, 2023

Merged to master

@srowen srowen closed this in 516d7b3 Apr 25, 2023
@LuciferYang
Copy link
Contributor Author

Thanks @srowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants