-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARK-1478 #405
SPARK-1478 #405
Conversation
Can one of the admins verify this patch? |
Jenkins, test this please. @tmalaska mind updating the title of the PR to include the title of the JIRA? It makes it easier when scanning the (long list) of active pull requests. |
Merged build triggered. |
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14118/ |
@tmalaska I did a cursory pass, this looks good. I will do a more detailed pass soon. However, there something you should know. I am in the middle of a PR ( #300 ) that tweaks the receiver API a little bit for greater stability and so a bit of your code will have a to change a little. This should go in pretty soon (couple of days, max). The PR has the changes necessary for the current FlumeReceiver. |
Yeah no problem. Thanks for taking the time to review my code. This is my first time committing with Scala :) Just let me know when ( #300 ) is done and I will re check out. Also when you have time I would love to know how else I could help. I was thinking of adding :
|
@tmalaska You probably missed Patrick's comment about updating the title of the PR. :) Please do update it with the title in the JIRA, so that its easier to identify in git's logs. Also, please update your branch by merging the master branch. I still see flume version 1.3 in the diff, which i expected to be 1.4. |
@@ -61,7 +61,7 @@ | |||
<dependency> | |||
<groupId>org.apache.flume</groupId> | |||
<artifactId>flume-ng-sdk</artifactId> | |||
<version>1.2.0</version> | |||
<version>1.3.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still 1.3? Have you merged master branch with your branch?
Aaah, crap, I did not realize that you submitted a new PR #566 for SPARK-1478! |
As soon as I figure out how. I will look into it after work. |
Pin periodic jobs of manageiq and openshift-ansible to master
SPARK-1478