Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-5339][BUILD] build/mvn doesn't work because of invalid URL for maven's tgz. #4124

Closed
wants to merge 3 commits into from
Closed

[SPARK-5339][BUILD] build/mvn doesn't work because of invalid URL for maven's tgz. #4124

wants to merge 3 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jan 20, 2015

build/mvn will automatically download tarball of maven. But currently, the URL is invalid.

srowen
srowen reviewed Jan 20, 2015
View reviewed changes
build/mvn
@@ -68,7 +68,7 @@ install_app() {
# Install maven under the build/ folder
install_mvn() {
install_app \
"http://apache.claz.org/maven/maven-3/3.2.3/binaries" \
"http://archive.apache.org/dist/maven/maven-3/3.2.3/binaries" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, point to 3.2.5? It's not ideal to point to archive.apache.org but at least it holds releases longer, whereas mirrors drop all but the latest point release in each line. I don't know of a redirector that would automatically send the request to a mirror though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if there are any redirectors, I'd like to use it but I also don't know so I chose archive.apache.org. For now, it's reliable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarutak can you update to 3.2.5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course.

@sarutak sarutak mentioned this pull request Jan 20, 2015
Closed
@sarutak
Copy link
Member Author

sarutak commented Jan 20, 2015

@pwendell I've updated to 3.2.5 and confirmed build works with build/mvn package -DskipTests.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25835 has finished for PR 4124 at commit ca26499.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25840 has finished for PR 4124 at commit 0e012d1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jan 20, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25846 has finished for PR 4124 at commit 0e012d1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 23, 2015

Test build #25989 has finished for PR 4124 at commit 6e96121.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@pwendell
Copy link
Contributor

Okay, LGTM good thanks!

@asfgit asfgit closed this in c094c73 Jan 26, 2015
@sarutak sarutak deleted the SPARK-5339 branch April 11, 2015 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarutak @SparkQA @pwendell @srowen