[SPARK-44138][SQL] Prohibit non-deterministic expressions, subqueries and aggregates in MERGE conditions #41694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and aggregates in MERGE conditions
|
The test failure is unrelated, triggered again. |
dongjoon-hyun
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
+1, LGTM. Thank you, @aokolnychyi .
Merged to master for Apache Spark 3.5.0.
|
Thank you, @dongjoon-hyun! |
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
… and aggregates in MERGE conditions This PR adds descriptive errors for cases when MERGE statements that are converted into executable plans by Spark contain unsupported expressions such as non-deterministic functions, subqueries, and aggregates. These changes are needed as the current version of the row-level framework does not support these operations. Keep in mind the new validation only applies to MERGE statements that are rewritten by `RewriteMergeIntoTable`. Data sources that inject their own implementation are NOT affected. No. This PR comes with tests. Closes apache#41694 from aokolnychyi/spark-44138. Authored-by: aokolnychyi <aokolnychyi@apple.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 87bc64b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds descriptive errors for cases when MERGE statements that are converted into executable plans by Spark contain unsupported expressions such as non-deterministic functions, subqueries, and aggregates.
Why are the changes needed?
These changes are needed as the current version of the row-level framework does not support these operations. Keep in mind the new validation only applies to MERGE statements that are rewritten by
RewriteMergeIntoTable. Data sources that inject their own implementation are NOT affected.Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR comes with tests.