[SPARK-44193][CONNECT] Implement GRPC exceptions interception for conversion #41743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyihong
changed the title
.../client/jvm/src/test/scala/org/apache/spark/sql/connect/client/SparkConnectClientSuite.scala
Show resolved
Hide resolved
amaliujia
reviewed
Jun 29, 2023
...t/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala
Show resolved
Hide resolved
amaliujia
reviewed
Jun 29, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcStub.scala
Outdated
Show resolved
Hide resolved
grundprinzip
reviewed
Jul 4, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcStub.scala
Outdated
Show resolved
Hide resolved
juliuszsompolski
approved these changes
Jul 4, 2023
grundprinzip
approved these changes
Jul 4, 2023
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/GrpcStub.scala
Outdated
Show resolved
Hide resolved
|
Followup: cc also @dillitz |
Yes, that's a good point. It would be nice to have similar (ideally the same) wrappers for both blocking and non-blocking stubs in ArtifactManager. |
HyukjinKwon
approved these changes
Jul 4, 2023
I'd be in favor of also adding functions to SparkConnectClient that the ArtifactManager, so that every RPC goes through SparkConnectClient. |
|
Merged to master. |
heyihong
changed the title
HyukjinKwon
pushed a commit
that referenced
this pull request
Jul 7, 2023
…k Connect ### What changes were proposed in this pull request? This PR introduces a configurable retry mechanism for the Scala `SparkConnectClient`. Parameters for the exponential backoff and a filter for exceptions to retry are passed to the client via the existing (extended) `Configuration` class. By default, only RuntimeStatusException: Unavailable triggers a retry - this mirrors the default retry behavior in the Python client. One might want to move the retry logic into the GRPC stub that will potentially be introduced [here](#41743). ### Why are the changes needed? There are a few existing exceptions that one might want to handle with a retry. For example, this would allow one to not exit with an exception when executing a command while the cluster is still starting. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tests included. Closes #41829 from dillitz/spark-44275-retries. Authored-by: Robert Dillitz <robert.dillitz@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…version ### What changes were proposed in this pull request? This PR adds GrpcStub and GrpcExceptionConverter utilities to the Spark Connect Scala Client so that the client can intercept the GRPC Exceptions and convert them to Spark related exceptions. The change converts all GRPC RuntimeStatusException to SparkException as a starting point. ### Why are the changes needed? Intercept GRPC Exceptions in Spark Connect Scala Client and convert them to Spark related exceptions for making exceptions more compatible with the existing behaviors ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests Closes apache#41743 from heyihong/SPARK-42554. Authored-by: Yihong He <yihong.he@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…k Connect ### What changes were proposed in this pull request? This PR introduces a configurable retry mechanism for the Scala `SparkConnectClient`. Parameters for the exponential backoff and a filter for exceptions to retry are passed to the client via the existing (extended) `Configuration` class. By default, only RuntimeStatusException: Unavailable triggers a retry - this mirrors the default retry behavior in the Python client. One might want to move the retry logic into the GRPC stub that will potentially be introduced [here](apache#41743). ### Why are the changes needed? There are a few existing exceptions that one might want to handle with a retry. For example, this would allow one to not exit with an exception when executing a command while the cluster is still starting. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tests included. Closes apache#41829 from dillitz/spark-44275-retries. Authored-by: Robert Dillitz <robert.dillitz@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds GrpcStub and GrpcExceptionConverter utilities to the Spark Connect Scala Client so that the client can intercept the GRPC Exceptions and convert them to Spark related exceptions. The change converts all GRPC RuntimeStatusException to SparkException as a starting point.
Why are the changes needed?
Intercept GRPC Exceptions in Spark Connect Scala Client and convert them to Spark related exceptions for making exceptions more compatible with the existing behaviors
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests