[SPARK-44409][SQL] Handle char/varchar in Dataset.to to keep consistent with others #41992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan who added this new API in 3.4 |
HyukjinKwon
approved these changes
Jul 17, 2023
|
thanks @HyukjinKwon , merged to master |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…nt with others ### What changes were proposed in this pull request? This PR replaces user-specified char/varchar in dataset.to API to make it consistent with other dataset/dataframe APIs ### Why are the changes needed? Currently, `INVALID_COLUMN_OR_FIELD_DATA_TYPE` is thrown when converting char to char, varchar to varchar. ### Does this PR introduce _any_ user-facing change? yes, different error classes when LEGACY_CHAR_VARCHAR_AS_STRING off and using char/vachar in `dataset.to`. While LEGACY_CHAR_VARCHAR_AS_STRING on, `to` is able to handle char/varchar ### How was this patch tested? new tests Closes apache#41992 from yaooqinn/SPARK-44409. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces user-specified char/varchar in dataset.to API to make it consistent with other dataset/dataframe APIs
Why are the changes needed?
Currently,
INVALID_COLUMN_OR_FIELD_DATA_TYPEis thrown when converting char to char, varchar to varchar.Does this PR introduce any user-facing change?
yes, different error classes when LEGACY_CHAR_VARCHAR_AS_STRING off and using char/vachar in
dataset.to. While LEGACY_CHAR_VARCHAR_AS_STRING on,tois able to handle char/varcharHow was this patch tested?
new tests