[SPARK-44341][SQL][PYTHON][FOLLOWUP] Move the base trait WindowEvaluatorFactoryBase to a single file #42106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Base to a single file
beliefer
changed the title
LuciferYang
approved these changes
Jul 21, 2023
|
The CI failure is unrelated to this PR. |
cloud-fan
approved these changes
Jul 21, 2023
|
thanks, merging to master! |
|
@cloud-fan @LuciferYang Thank you. |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…torFactoryBase to a single file ### What changes were proposed in this pull request? apache#41939 defined the computing logic through PartitionEvaluator API and use it in `WindowExec` and `WindowInPandasExec`. According to the comment apache#41939 (comment), this PR want move the base trait `WindowEvaluatorFactoryBase` to a single file. ### Why are the changes needed? Improve the code. ### Does this PR introduce _any_ user-facing change? 'No'. Just update inner implementation. ### How was this patch tested? N/A Closes apache#42106 from beliefer/SPARK-44341_followup. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41939 defined the computing logic through PartitionEvaluator API and use it in
WindowExecandWindowInPandasExec.According to the comment #41939 (comment), this PR want move the base trait
WindowEvaluatorFactoryBaseto a single file.Why are the changes needed?
Improve the code.
Does this PR introduce any user-facing change?
'No'.
Just update inner implementation.
How was this patch tested?
N/A