Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5417] Remove redundant executor-id set() call #4213

Closed
wants to merge 1 commit into from

Conversation

ryan-williams
Copy link
Contributor

This happens inside SparkEnv initialization as of #4194

This happens inside SparkEnv initialization as of apache#4194
@SparkQA
Copy link

SparkQA commented Jan 27, 2015

Test build #26132 has started for PR 4213 at commit b3e4f7b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 27, 2015

Test build #26132 has finished for PR 4213 at commit b3e4f7b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Rating(userId: Int, movieId: Int, rating: Float, timestamp: Long)
    • case class Movie(movieId: Int, title: String, genres: Seq[String])
    • case class Params(
    • class ALS extends Estimator[ALSModel] with ALSParams
    • case class RatingBlock(srcIds: Array[Int], dstIds: Array[Int], ratings: Array[Float])
    • protected case class Keyword(str: String)
    • class SqlLexical extends StdLexical

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26132/
Test PASSed.

@andrewor14
Copy link
Contributor

LGTM I've been wanting to do the same merging into master.

@asfgit asfgit closed this in a731314 Jan 28, 2015
@ryan-williams
Copy link
Contributor Author

thanks @andrewor14, to be clear, afaik the removed line here only became redundant on Sunday with #4194; did you mean you've been wanting to do the same since then? Or has this been redundant for longer, unbeknownst to me?

@andrewor14
Copy link
Contributor

No, only as of #4194. After I merged that I realized we still set it elsewhere redundantly but didn't really get to removing it myself.

@srowen
Copy link
Member

srowen commented Feb 27, 2015

Since the commit this depends on was in 1.2 (1f8b718) and this was tagged for back-port into 1.2, after 1.2.1 was released I presume (like #4224) I'm going to backport into 1.2.

asfgit pushed a commit that referenced this pull request Feb 27, 2015
This happens inside SparkEnv initialization as of #4194

Author: Ryan Williams <ryan.blake.williams@gmail.com>

Closes #4213 from ryan-williams/exec-id-set and squashes the following commits:

b3e4f7b [Ryan Williams] Remove redundant executor-id set() call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants