[SPARK-44287][SQL][FOLLOWUP] Set partition index correctly #42185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Jul 27, 2023
| @@ -279,40 +279,36 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper { | |||
| } | |||
| withSession(extensions) { session => | |||
| session.conf.set(SQLConf.ADAPTIVE_EXECUTION_ENABLED, enableAQE) | |||
| Seq(true, false).foreach { enableEvaluator => | |||
There was a problem hiding this comment.
According to the previous discussion, we don't need to test it as we are already using the evaluator by default, and we can test RDD#mapPartitionsWithEvaluator when we use it by default.
yaooqinn
approved these changes
Jul 27, 2023
LuciferYang
approved these changes
Jul 27, 2023
viirya
approved these changes
Jul 27, 2023
This was referenced Jul 27, 2023
cloud-fan
added a commit
that referenced
this pull request
Jul 28, 2023
### What changes were proposed in this pull request? This is a followup of #41839, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes #42185 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit bf1bbc5) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
thanks for the review, merging to master/3.5! |
beliefer
reviewed
Jul 28, 2023
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This is a followup of apache#41839, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes apache#42185 from cloud-fan/follow. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #41839, to set the partition index correctly even if it's not used for now. It also contains a few code cleanup.
Why are the changes needed?
future-proof
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests