[SPARK-44424][PYTHON][CONNECT][FOLLOW-UP] Import Connect related libraries after checking dependencies #42311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Aug 2, 2023
HyukjinKwon
added a commit
that referenced
this pull request
Aug 2, 2023
…aries after checking dependencies ### What changes were proposed in this pull request? This PR is a followup of #42235 that fixes the Connect related import after the dependency checking. ### Why are the changes needed? In order to show the end users a nice error message for optional dependencies instead of just saying that they were not found. ### Does this PR introduce _any_ user-facing change? No, the PR has not been released out yet. ### How was this patch tested? Manually. Closes #42311 from HyukjinKwon/SPARK-44424-folowup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 7b9057b) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…aries after checking dependencies ### What changes were proposed in this pull request? This PR is a followup of apache#42235 that fixes the Connect related import after the dependency checking. ### Why are the changes needed? In order to show the end users a nice error message for optional dependencies instead of just saying that they were not found. ### Does this PR introduce _any_ user-facing change? No, the PR has not been released out yet. ### How was this patch tested? Manually. Closes apache#42311 from HyukjinKwon/SPARK-44424-folowup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #42235 that fixes the Connect related import after the dependency checking.
Why are the changes needed?
In order to show the end users a nice error message for optional dependencies instead of just saying that they were not found.
Does this PR introduce any user-facing change?
No, the PR has not been released out yet.
How was this patch tested?
Manually.