[WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value in codegen when first value is null #42433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove73@gmail.com>
This was referenced Aug 10, 2023
Signed-off-by: Andy Grove <andygrove73@gmail.com>
|
This isn't the correct fix. Will reopen once working. |
|
reoponed as #42434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @cloud-fan here, #41432 fixed a formatting issue when casting map to string but did not fix it in the codegen case.
The fix is a one-liner, but I am not sure how to add a unit test for this and could use some guidance.