[SPARK-44866][SQL] Add SnowflakeDialect to handle BOOLEAN type correctly
#42545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2023 23:15
In snowflake, the BIT data type does not exist. A Boolean is a Boolean. That's what this is about.
hayssams
changed the title
|
Could you file a ticket? https://issues.apache.org/jira/browse/SPARK |
hayssams
changed the title
|
Juste created the ticket https://issues.apache.org/jira/browse/SPARK-44866 |
wangyum
reviewed
Aug 19, 2023
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
Outdated
Show resolved
Hide resolved
wangyum
reviewed
Aug 19, 2023
sql/core/src/main/scala/org/apache/spark/sql/jdbc/SnowflakeDialect.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
changed the title
SnowflakeDialect to handle BOOLEAN type correctly
There was a problem hiding this comment.
Thank you for making a PR, @hayssams .
Since this PR adds a new dialect, I need to ask if you are using this code without any other issues.
|
Hi @DongJoon
Yes we are using this PR without any other issue.
On the other hand before submitting this PR, I looked at the default JDBC
mapping and did not find any other incompatibility
…On Fri 8 Sep 2023 at 22:51 Dongjoon Hyun ***@***.***> wrote:
***@***.**** commented on this pull request.
Thank you for making a PR, @hayssams <https://github.com/hayssams> .
Since this PR adds a new dialect, I need to ask if you are using this code
without any other issues.
—
Reply to this email directly, view it on GitHub
<#42545 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAS4ACE34FTZ3OUURND777DXZOAOXANCNFSM6AAAAAA3USZKMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you for the confirmation. |
dongjoon-hyun
approved these changes
Sep 8, 2023
|
Welcome to the Apache Spark community and congratulations for your first commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Snowflake a BOOLEAN data type exist but not the BIT data type.
This PR adds
SnowflakeDialectto override the default JdbcDialect and redefine the default mapping behaviour for the boolean type. Currently, it's mapped toBIT(1)type.spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
Line 149 in a663c0b
Why are the changes needed?
The BIT type does not exist in Snowflake. This cause the Spark Job to fail on table creation.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test and directly on Snowflake