[SPARK-44907][PYTHON][CONNECT] DataFrame.join should throw IllegalArgumentException for invalid join types
#42603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Aug 22, 2023
itholic
approved these changes
Aug 22, 2023
zhengruifeng
added a commit
that referenced
this pull request
Aug 23, 2023
…gumentException for invalid join types ### What changes were proposed in this pull request? `DataFrame.join` should throw IllegalArgumentException for invalid join types ### Why are the changes needed? all valid join types have already been supported, for an unknown one, should throw `IllegalArgumentException` now ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? enabled UT ### Was this patch authored or co-authored using generative AI tooling? NO Closes #42603 from zhengruifeng/test_df_join_type. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 7e5250a) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
|
thanks! merged to master and branch-3.5 |
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…gumentException for invalid join types ### What changes were proposed in this pull request? `DataFrame.join` should throw IllegalArgumentException for invalid join types ### Why are the changes needed? all valid join types have already been supported, for an unknown one, should throw `IllegalArgumentException` now ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? enabled UT ### Was this patch authored or co-authored using generative AI tooling? NO Closes apache#42603 from zhengruifeng/test_df_join_type. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DataFrame.joinshould throw IllegalArgumentException for invalid join typesWhy are the changes needed?
all valid join types have already been supported, for an unknown one, should throw
IllegalArgumentExceptionnowDoes this PR introduce any user-facing change?
yes
How was this patch tested?
enabled UT
Was this patch authored or co-authored using generative AI tooling?
NO