[SPARK-44986][DOCS] There should be a gap at the bottom of the HTML #42702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
dongjoon-hyun
requested changes
Aug 28, 2023
docs/quick-start.md
Outdated
| @@ -470,19 +470,19 @@ Congratulations on running your first Spark application! | |||
| * For an in-depth overview of the API, start with the [RDD programming guide](rdd-programming-guide.html) and the [SQL programming guide](sql-programming-guide.html), or see "Programming Guides" menu for other components. | |||
| * For running applications on a cluster, head to the [deployment overview](cluster-overview.html). | |||
| * Finally, Spark includes several samples in the `examples` directory | |||
| ([Scala]({{site.SPARK_GITHUB_URL}}/tree/master/examples/src/main/scala/org/apache/spark/examples), | |||
| ([Python]({{site.SPARK_GITHUB_URL}}/tree/master/examples/src/main/python), | |||
There was a problem hiding this comment.
Are there any other places where the Python one is not the first example?
+1, it is irrelevant. Should open a separate PR if needed |
|
Okay, Let me split it into a new separate PR, because I found similar order issues on other pages. |
zhengruifeng
approved these changes
Sep 1, 2023
dongjoon-hyun
approved these changes
Sep 8, 2023
|
Merged to master for Apache Spark 4.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to add gap at the bottom of the HTML.
Why are the changes needed?
The old document style has good white space at the bottom, but the latest document has lost this piece, which looks unattractive and borderless.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual testing.
Was this patch authored or co-authored using generative AI tooling?
No.