Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45044][PYTHON][DOCS] Refine docstring of groupBy/rollup/cube #42834

Closed
wants to merge 4 commits into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Sep 6, 2023

What changes were proposed in this pull request?

This pr aims to refine docstring of DataFrame.groupBy/rollup/cube and fix potentially wrong underline length.

Why are the changes needed?

  • To improve PySpark documentation.

  • Fix potentially wrong underline length.
    image

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Pass GA.
  • Manually test.
cd python/docs
make clean html

Was this patch authored or co-authored using generative AI tooling?

No.

@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon @zhengruifeng

@zhengruifeng
Copy link
Contributor

thanks @panbingkun , would you mind waiting for #42832 which happen to add new feature to rollup/cube ?

@panbingkun
Copy link
Contributor Author

thanks @panbingkun , would you mind waiting for #42832 which happen to add new feature to rollup/cube ?

Okay, let's wait for it.

@panbingkun
Copy link
Contributor Author

@zhengruifeng
I have synchronized the changes after #42832 to this PR.

@HyukjinKwon
Copy link
Member

Merged to master.

@zhengruifeng
Copy link
Contributor

thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants