[SPARK-45231][INFRA] Remove unrecognized and meaningless command about Ammonite from the GA testing workflow.
#42993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
changed the title
panbingkun
changed the title
Ammonite from the GA testing workflow.
vicennial
approved these changes
Sep 20, 2023
|
cc @hvanhovell |
|
Merged to master. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Oct 7, 2023
…t `Ammonite` from the GA testing workflow ### What changes were proposed in this pull request? The pr aims to remove unrecognized and meaningless command about `amm` from the GA testing workflow. ### Why are the changes needed? - When I observed GA's logs, I found the following logs: ``` Run # Fix for TTY related issues when launching the Ammonite REPL in tests. sh: 1: amm: not found ``` eg: https://github.com/apache/spark/actions/runs/6243934856/job/16950117287#step:10:21 https://github.com/panbingkun/spark/actions/runs/6232228999/job/16924063382#step:10:22 Obviously, `amm` did not recognize it. Through trial and error, it was found that the above command do not need to be executed in our GA. - Enhance maintainability and reduce misunderstandings. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42993 from panbingkun/remove_amm_test. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 23, 2023
…mmand about Ammonite from the GA testing workflow ### What changes were proposed in this pull request? The pr is followup #42993 ### Why are the changes needed? Remove unrecognized and meaningless command about Ammonite from the GA testing workflow. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44386 from panbingkun/SPARK-45231_FOLLOWUP. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to remove unrecognized and meaningless command about
ammfrom the GA testing workflow.Why are the changes needed?
eg:
https://github.com/apache/spark/actions/runs/6243934856/job/16950117287#step:10:21
https://github.com/panbingkun/spark/actions/runs/6232228999/job/16924063382#step:10:22
Obviously,
ammdid not recognize it. Through trial and error, it was found that the above command do not need to be executed in our GA.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.