-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45431][DOCS] Document new SSL RPC feature #43240
Conversation
e71d443
to
7be2a62
Compare
@mridulm could you look at this one when you have a chance? (or recommend a different reviewer if someone else is more suited to review docs PRs) |
+CC @JoshRosen as well. |
a781f10
to
fa9ca55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, except for the open discussion.
Sorry for the delay in reviewing this - not sure why I was not notified of the update by github ...
Merged to master. |
What changes were proposed in this pull request?
Add some documentation to clarify the new flags being added and how this feature interacts with existing SSL and encryption support. It's a little confusing so feedback is welcome.
Note I am not sure if it's best practice to merge this after the feature is fully merged - thought I would put this up now since it's unblocked.
Why are the changes needed?
New features require documentation so users can understand how to use them.
Does this PR introduce any user-facing change?
Yes, this is adding documentation for a new feature
How was this patch tested?
Not applicable, this is documentation
Was this patch authored or co-authored using generative AI tooling?
No