Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table #43258

Closed
wants to merge 6 commits into from
Closed

[SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table #43258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e84771
[SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table
lyy-pineapple Oct 7, 2023
2332c7d
remove comments
lyy-pineapple Oct 7, 2023
92c047f
move function to tail
lyy-pineapple Oct 7, 2023
b25978e
remove comments
lyy-pineapple Oct 7, 2023
5d0a242
Remove session clone, uncache table and drop table at finally
lyy-pineapple Oct 7, 2023
84a6bb5
remove unuse cache
lyy-pineapple Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,14 @@ class JDBCOptions(
.get(JDBC_PREFER_TIMESTAMP_NTZ)
.map(_.toBoolean)
.getOrElse(SQLConf.get.timestampType == TimestampNTZType)

override def hashCode: Int = this.parameters.hashCode()

override def equals(other: Any): Boolean = other match {
case otherOption: JDBCOptions =>
otherOption.parameters.equals(this.parameters)
case _ => false
}
}

class JdbcOptionsInWrite(
Expand Down
15 changes: 15 additions & 0 deletions ...test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import org.apache.spark.sql.{AnalysisException, QueryTest, Row}
import org.apache.spark.sql.catalyst.analysis.{NoSuchNamespaceException, TableAlreadyExistsException}
import org.apache.spark.sql.catalyst.parser.ParseException
import org.apache.spark.sql.catalyst.util.CharVarcharUtils
import org.apache.spark.sql.execution.columnar.InMemoryTableScanExec
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SharedSparkSession
import org.apache.spark.sql.types._
Expand Down Expand Up @@ -512,4 +513,18 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}

test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
withTable("h2.test.cache_t") {
withConnection { conn =>
conn.prepareStatement(
"""CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
|name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
}
sql("INSERT OVERWRITE h2.test.cache_t SELECT 1 AS id, 'a' AS name")
sql("CACHE TABLE t1 SELECT id, name FROM h2.test.cache_t")
val plan = sql("select * from t1").queryExecution.sparkPlan
assert(plan.isInstanceOf[InMemoryTableScanExec])
}
}
}